Ruby 3.3 compatibility - #1
Open
danielxvu wants to merge 1 commit into
Open
Conversation
danielxvu
force-pushed
the
ruby-3.3
branch
3 times, most recently
from
June 25, 2026 08:18
46bf2a3 to
62b0c4a
Compare
padrino-core 0.14.4's Router#map built two regexps with the 3-arg Regexp.new(str, options, 'n') form removed in Ruby 3.2+. Replace the trailing 'n' kcode with Regexp::NOENCODING, preserving the original options (path: none; host: IGNORECASE, which the legacy `true` flag enabled). Kept 2.7-compatible; only the padrino-core sub-gem of this monorepo is patched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 compatibility patch consumed by Roll20/d20app (ODSY-1142, PR https://github.com/Roll20/d20app/pull/10896). padrino-core: 3-arg Regexp.new kcode -> Regexp::NOENCODING for Ruby 3.x. Kept 2.7-safe so it can land before the d20app runtime flip.