Add Support for Playwright #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julliancalkins
force-pushed
the
ccc-days-2025
branch
from
303a772 to
1d610cd
Compare
timirwin
approved these changes
Aug 7, 2025
lib/generators/rolemodel/testing/rspec/templates/support/helpers.rb
Outdated
Show resolved
Hide resolved
Comment on lines
20
to
21
| gem 'webdrivers' | ||
| gem 'marsh_grass' | ||
| gem 'pry' |
There was a problem hiding this comment.
Do we need pry? And alphabetize?
Suggested change
| gem 'webdrivers' | |
| gem 'marsh_grass' | |
| gem 'pry' | |
| gem 'marsh_grass' | |
| gem 'webdrivers' |
There was a problem hiding this comment.
pry is currently a dependency of marsh_grass.
There was a problem hiding this comment.
Hmmm. We were thinking we might be able to remove that dependency but haven't gotten there yet.
lib/generators/rolemodel/jasmine_playwright/templates/support/react.mjs
Outdated
Show resolved
Hide resolved
lib/generators/rolemodel/jasmine_playwright/templates/example_spec.js
Outdated
Show resolved
Hide resolved
lib/generators/rolemodel/jasmine_playwright/jasmine_playwright_generator.rb
Outdated
Show resolved
Hide resolved
julliancalkins
force-pushed
the
ccc-days-2025
branch
from
f145fc8 to
cfd9703
Compare
timirwin
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We wanted a new project to easily set up playwright for running system tests using RoleModel Rails generators. Specifically, the capybara-playwright-driver gem for rspec, and the jasmine playwright runner for javascript tests.
What Changed
Pre-merge checklist
lib/rolemodel_rails/version.rb