fix: Execute winSignKms.js as child process instead of requiring #716
Annotations
5 errors and 1 notice
Run /./workspaces/desktop-release-action
Command failed: node -e " const sign = require('./build/winSignKms.js'); const config = *** path: 'D:/a/Rocket.Chat.Electron/Rocket.Chat.Electron/dist/rocketchat-4.9.0-win-arm64.appx', name: 'Rocket.Chat', site: 'https://rocket.chat' ***; sign(config).then(() => *** console.log('Successfully signed'); process.exit(0); ***).catch(err => *** console.error('Signing failed:', err); process.exit(1); ***); "
[winSignKms] jsign stderr: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
[winSignKms] jsign stdout: Adding Authenticode signature to D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\dist\rocketchat-4.9.0-win-arm64.appx
Signing failed: Error: [winSignKms] jsign failed with exit code 1: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
at signWindowsOnWindows (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:389:11)
at signWithGoogleKms (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:124:12)
at [eval]:1:266
at runScriptInThisContext (node:internal/vm:209:10)
at node:internal/process/execution:449:12
at [eval]-wrapper:6:24
at runScriptInContext (node:internal/process/execution:447:60)
at evalFunction (node:internal/process/execution:87:30)
at evalScript (node:internal/process/execution:99:3)
at node:internal/main/eval_string:74:3
|
Run /./workspaces/desktop-release-action
Failed to build Windows packages: Error: Command failed: node -e " const sign = require('./build/winSignKms.js'); const config = *** path: 'D:/a/Rocket.Chat.Electron/Rocket.Chat.Electron/dist/rocketchat-4.9.0-win-arm64.appx', name: 'Rocket.Chat', site: 'https://rocket.chat' ***; sign(config).then(() => *** console.log('Successfully signed'); process.exit(0); ***).catch(err => *** console.error('Signing failed:', err); process.exit(1); ***); "
[winSignKms] jsign stderr: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
[winSignKms] jsign stdout: Adding Authenticode signature to D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\dist\rocketchat-4.9.0-win-arm64.appx
Signing failed: Error: [winSignKms] jsign failed with exit code 1: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
at signWindowsOnWindows (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:389:11)
at signWithGoogleKms (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:124:12)
at [eval]:1:266
at runScriptInThisContext (node:internal/vm:209:10)
at node:internal/process/execution:449:12
at [eval]-wrapper:6:24
at runScriptInContext (node:internal/process/execution:447:60)
at evalFunction (node:internal/process/execution:87:30)
at evalScript (node:internal/process/execution:99:3)
at node:internal/main/eval_string:74:3
|
Run /./workspaces/desktop-release-action
stderr: [winSignKms] jsign stderr: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
[winSignKms] jsign stdout: Adding Authenticode signature to D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\dist\rocketchat-4.9.0-win-arm64.appx
Signing failed: Error: [winSignKms] jsign failed with exit code 1: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
at signWindowsOnWindows (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:389:11)
at signWithGoogleKms (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:124:12)
at [eval]:1:266
at runScriptInThisContext (node:internal/vm:209:10)
at node:internal/process/execution:449:12
at [eval]-wrapper:6:24
at runScriptInContext (node:internal/process/execution:447:60)
at evalFunction (node:internal/process/execution:87:30)
at evalScript (node:internal/process/execution:99:3)
at node:internal/main/eval_string:74:3
|
Run /./workspaces/desktop-release-action
stdout: [winSignKms] Windows-based signing with jsign + Google Cloud KMS
[winSignKms] jsign found at: C:\ProgramData\chocolatey\lib\jsign\tools\jsign.cmd
[winSignKms] gcloud found at: C:\ProgramData\chocolatey\lib\gcloudsdk\tools\google-cloud-sdk\bin\gcloud.cmd
[winSignKms] jsign available: true (C:\ProgramData\chocolatey\lib\jsign\tools\jsign.cmd)
[winSignKms] gcloud available: true (C:\ProgramData\chocolatey\lib\gcloudsdk\tools\google-cloud-sdk\bin\gcloud.cmd)
[winSignKms] Using project: rocketchat-rnd
[winSignKms] Using location: us
[winSignKms] Using keyring: Electron_Desktop_App
[winSignKms] Using key: Electron_Desktop_App_Key
[winSignKms] Getting access token from gcloud...
[winSignKms] Successfully obtained access token
[winSignKms] Running jsign with masked token...
[winSignKms] jsign --storetype GOOGLECLOUD --keystore *** --storepass [MASKED] --alias Electron_Desktop_App_Key --certfile D:\a\_temp\codesigning\user.crt --tsaurl http://timestamp.digicert.com D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\dist\rocketchat-4.9.0-win-arm64.appx
|
Run /./workspaces/desktop-release-action
Failed to sign rocketchat-4.9.0-win-arm64.appx: Command failed: node -e " const sign = require('./build/winSignKms.js'); const config = *** path: 'D:/a/Rocket.Chat.Electron/Rocket.Chat.Electron/dist/rocketchat-4.9.0-win-arm64.appx', name: 'Rocket.Chat', site: 'https://rocket.chat' ***; sign(config).then(() => *** console.log('Successfully signed'); process.exit(0); ***).catch(err => *** console.error('Signing failed:', err); process.exit(1); ***); "
[winSignKms] jsign stderr: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
[winSignKms] jsign stdout: Adding Authenticode signature to D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\dist\rocketchat-4.9.0-win-arm64.appx
Signing failed: Error: [winSignKms] jsign failed with exit code 1: jsign: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
java.lang.IllegalArgumentException: The app manifest publisher name (null) must match the subject name of the signing certificate (C=US,ST=Delaware,O=Rocket.Chat Technologies Corp.,CN=Rocket.Chat Technologies Corp.)
at net.jsign.appx.APPXFile.validate(APPXFile.java:184)
at net.jsign.AuthenticodeSigner.sign(AuthenticodeSigner.java:361)
at net.jsign.SignerHelper.sign(SignerHelper.java:454)
at net.jsign.SignerHelper.execute(SignerHelper.java:305)
at net.jsign.JsignCLI.execute(JsignCLI.java:221)
at net.jsign.JsignCLI.main(JsignCLI.java:57)
Try `jsign --help' for more information.
at signWindowsOnWindows (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:389:11)
at signWithGoogleKms (D:\a\Rocket.Chat.Electron\Rocket.Chat.Electron\build\winSignKms.js:124:12)
at [eval]:1:266
at runScriptInThisContext (node:internal/vm:209:10)
at node:internal/process/execution:449:12
at [eval]-wrapper:6:24
at runScriptInContext (node:internal/process/execution:447:60)
at evalFunction (node:internal/process/execution:87:30)
at evalScript (node:internal/process/execution:99:3)
at node:internal/main/eval_string:74:3
|
The windows-latest label will migrate from Windows Server 2022 to Windows Server 2025 beginning September 2, 2025. For more information see https://github.com/actions/runner-images/issues/12677
|
Loading