Bug fixes symmetric predicates/edges showing arrows (#257) #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of solid lines (Issue #257)
Woozl
requested changes
May 21, 2025
Member
Woozl
left a comment
Woozl
left a comment
There was a problem hiding this comment.
Looks great! Great job getting this working quickly. I just suggested one small style fix to follow the camelCase naming conventions.
It's a bit confusing because there are some places in the app that read from external data sources that are written in Python, where the convention is to use snake_case. But for these variables we're creating in Javascript, lets stick to the convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where symmetrical predicates/edges were displaying arrows instead of solid lines (Issue #257)