Skip to content

Conversation

@impandimi
Copy link
Contributor

@impandimi impandimi commented Oct 23, 2025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • In progress (fix or feature that isn't completed / ignore checklist if this is marked)

Checklist:

  • My code follows the style guidelines of this project
  • Someone have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@impandimi impandimi requested a review from Raptura October 23, 2025 01:26
Copy link
Member

@Raptura Raptura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review changes

public class ElevatorArmConstants {
// the CAN ID of the arm motor on the elevator
public static final int kElevatorArmId = 15;
public static final int kElevatorArmId = 6; //TODO: almost certain this got changed to 6, check in revclient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is correct and then delete the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants