Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@ripple-ts/adapter
@ripple-ts/adapter-bun
@ripple-ts/adapter-node
@ripple-ts/cli
create-ripple
@tsrx/eslint-parser
@tsrx/eslint-plugin
@tsrx/prettier-plugin
ripple
@ripple-ts/rollup-plugin
@tsrx/typescript-plugin
@ripple-ts/vite-plugin
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
This is a breaking semantic change for anyone relying on reactive plain-
ifguards orreturninside@tryblocks; compiler output and Solid/Ripple runtime behavior shift in core template lowering paths.Overview
Aligns template semantics so only
@if/@for/@switch/@trylower to template control flow; plainif/ loops /switch/tryin@{ … }compile like normal function bodies (JSXreturn→tsrx_element), andreturninside@try/@catch/@pendingis rejected with the same template-return diagnostic as other@-blocks.On Ripple, the compiler drops
return_guardand related_$_.ifwrapping: earlyreturnis a real early return, so trailing markup is skipped without guard flags (client/server snapshots updated). Analysis no longer errors on plain loops;break/continue/ return rules apply only when the enclosing loop is a@for(metadata.tsrxDirective === 'for').On Solid, plain guards like
if (signal()) return …are no longer lifted to<Show>—they run once at setup; reactive conditionals require@if.@-directives and control flow that canthrowstill lower reactively. SharedisTemplate*Nodehelpers move to@tsrx/corefor consistent directive detection.Tests and runtime expectations are updated for the new guard behavior (e.g. Vite Solid: flipping a signal after a plain guard does not swap branches).
Reviewed by Cursor Bugbot for commit 0c7cd93. Bugbot is set up for automated code reviews on this repo. Configure here.