drop chozo+extlib in configuration parsing (fixes #123)#125
Open
mbakhoff wants to merge 1 commit intoRiotGamesMinions:masterfrom
Open
drop chozo+extlib in configuration parsing (fixes #123)#125mbakhoff wants to merge 1 commit intoRiotGamesMinions:masterfrom
mbakhoff wants to merge 1 commit intoRiotGamesMinions:masterfrom
Conversation
Author
|
note that the test "NexusCli::Configuration#repository when repository has illegal values makes it legal" (configuration_spec.rb:143) was already broken from 4130a67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extlib breaks keywords arguments (issue #123). this PR removes the extlib dependency.
chozo breaks ruby 2.3, it has an incompatible dig method (see [1]). this PR also removes the chozo dependency.
[1] killbill/killbill#714