Fix: Update pkg assets path for Windows build #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pkg.assets` configuration in `package.json` was pointing to a non-existent `controller/public` directory. This commit updates the path to `decktap-web/dist/**/*`, which is the correct output directory for the web application's build process. This change ensures that the web interface assets are included in the packaged executable, allowing the application to function correctly when built for Windows using `pkg`.
Owner
|
Have you tested the new build after packaging to simulate keyboard operations normally? |
Owner
|
Judging from what I have learned so far, using pkg packaging destroys the ability of nut-js to call the system native interface (this is why I removed pkg-related configuration on the main branch). So at the moment you can only run the project directly from the project using nodejs, and I will try to build the project using electron to solve the problem later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pkg.assetsconfiguration inpackage.jsonwas pointing to a non-existentcontroller/publicdirectory. This commit updates the path todecktap-web/dist/**/*, which is the correct output directory for the web application's build process. This change ensures that the web interface assets are included in the packaged executable, allowing the application to function correctly when built for Windows usingpkg.