Skip to content

test: assert deterministic close-period preview across shuffled holders - #707

Merged
thlpkee20-wq merged 1 commit into
RevoraOrg:masterfrom
pchieneye:test/deterministic-ordering-shuffle
Jul 30, 2026
Merged

test: assert deterministic close-period preview across shuffled holders#707
thlpkee20-wq merged 1 commit into
RevoraOrg:masterfrom
pchieneye:test/deterministic-ordering-shuffle

Conversation

@pchieneye

Copy link
Copy Markdown

test: assert deterministic close-period preview across shuffled holders

Summary

This PR adds a regression test to ensure close-period preview distribution output is deterministic regardless of holder-list ordering.

What changed

  • Added a regression test covering shuffled holder-order inputs for close-period preview behavior.
  • Added a deterministic shuffle helper for reproducible test fixtures.
  • Canonicalized the preview payout ordering so the distribution output remains stable across equivalent holder sets.

Why

The close-period preview should not depend on the incoming order of holders. This change ensures that the same set of holders produces the same preview/distribution result even when the input order is shuffled.

Validation

  • Added a targeted regression test for the deterministic ordering behavior.
  • Kept the change scoped to the close-period preview logic and its test coverage.

Closes: #602

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@pchieneye Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@thlpkee20-wq
thlpkee20-wq merged commit 8994552 into RevoraOrg:master Jul 30, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add deterministic-ordering test asserting identical outputs across shuffled holder-list inputs

3 participants