Skip to content

Another PR that needs approval#10

Open
pkaminski wants to merge 12 commits intomasterfrom
pkaminski-patch-10
Open

Another PR that needs approval#10
pkaminski wants to merge 12 commits intomasterfrom
pkaminski-patch-10

Conversation

@pkaminski
Copy link
Copy Markdown
Member

@pkaminski pkaminski commented Aug 18, 2023 •
edited
Loading

This change is Reviewable

pkaminski-test
pkaminski-test requested changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it.

pkaminski-test
pkaminski-test approved these changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmk

pkaminski-test
pkaminski-test reviewed Sep 16, 2023
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @pkaminski)

pkaminski-test
pkaminski-test reviewed Sep 16, 2023
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)

pkaminski-test
pkaminski-test reviewed Sep 16, 2023
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)

pkaminski
pkaminski commented Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)

pkaminski
pkaminski commented Oct 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pkaminski-test asdfh adsf

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)

pkaminski
pkaminski commented Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adsf

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)

@pkaminski
Copy link
Copy Markdown
Member Author

pkaminski commented Oct 17, 2023

-- commits line 2 at r1:
ad-hoc comment

@pkaminski pkaminski added the documentation Improvements or additions to documentation label Oct 17, 2023
@pkaminski pkaminski self-assigned this Oct 17, 2023
@pkaminski
Copy link
Copy Markdown
Member Author

pkaminski commented Oct 17, 2023

+documentation +@pkaminski +reviewer:@pkaminski-test @pkaminski-test

pkaminski
pkaminski commented Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full publish

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @pkaminski-test)

@pkaminski
Copy link
Copy Markdown
Member Author

pkaminski commented Oct 17, 2023

-- commits line 2 at r1:

Previously, pkaminski (Piotr Kaminski) wrote…

ad-hoc comment

another

@pkaminski pkaminski added the bug Something isn't working label Oct 17, 2023
pkaminski
pkaminski commented Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+bug

Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @pkaminski-test)

-- commits line 1 at r1:
@pkaminski-test mention in new comment.

pkaminski
pkaminski commented Nov 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo

Reviewed 1 of 1 files at r3.
Reviewable status: undefined

pkaminski
pkaminski commented Nov 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bar

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)

pkaminski
pkaminski commented Nov 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)

-- commits line 2 at r1:

Previously, pkaminski (Piotr Kaminski) wrote…

another

hello

pkaminski
pkaminski commented Nov 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)

-- commits line 2 at r1:

Previously, pkaminski (Piotr Kaminski) wrote…

hello

bar

pkaminski
pkaminski commented May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @pkaminski-test)

@pkaminski pkaminski requested a review from a team May 9, 2024 02:21
pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski pkaminski requested a review from a team May 16, 2024 17:48
pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously, no.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski pkaminski requested a review from a team May 16, 2024 17:51
pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski pkaminski requested a review from a team May 16, 2024 17:53
pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bar

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski pkaminski requested a review from a team May 16, 2024 18:02
pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blah.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski pkaminski requested a review from a team May 16, 2024 18:02
pkaminski-test
pkaminski-test requested changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adsf

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

pkaminski
pkaminski commented Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion

-- commits line 2 at r1:

Previously, pkaminski (Piotr Kaminski) wrote…

bar

Code snippet:

adsf

pkaminski
pkaminski commented Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion

-- commits line 2 at r1:
asdf

@pkaminski pkaminski requested a review from a team July 15, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkaminski-test pkaminski-test pkaminski-test requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@pkaminski pkaminski

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pkaminski @pkaminski-test