-
Notifications
You must be signed in to change notification settings - Fork 8
feat/AB#74292 People picker #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x.x
Are you sure you want to change the base?
feat/AB#74292 People picker #1792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…aired a logic bug in tagbox widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As suggested by Nathan in above comment, added support in grids, and in summary cards: mimicked behavior of users questions.
- Repaired a bug regarding tagbox widget linked to one of my previous tickets (people tagbox would raise an error).
People question should work fine now.
…ion # Conflicts: # libs/shared/src/lib/survey/init.ts
|
request to do for pagination: query { |
putting as draft this one A few things to change:
I'll assign you the ticket on devops |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to double-check but look overall fine
libs/shared/src/lib/components/ui/core-grid/grid/grid.component.html
Outdated
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Outdated
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Outdated
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great PR from the GOAT Matthieu
@Matthis-M-ReliefApps @MwanPygmay most of it is working as expected, but I still see one issue 😅 the charts are not working: ![]() We should see similar data than the one we see in other widgets |
Still to be done:
|
Description
This creates a dropdown with multiple selections, that allows to search for users
Useful links
Type of change
Please delete options that are not relevant.
Screenshots
Screen.Recording.2023-10-09.at.09.09.28.mov
Checklist:
( * == Mandatory )