Skip to content

feat/AB#74292 People picker #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: 2.x.x
Choose a base branch
from

Conversation

TaiKamilla
Copy link
Contributor

@TaiKamilla TaiKamilla commented Sep 4, 2023

Description

This creates a dropdown with multiple selections, that allows to search for users

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (refactor or addition to existing functionality)

Screenshots

Screen.Recording.2023-10-09.at.09.09.28.mov

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@TaiKamilla TaiKamilla requested a review from a team September 4, 2023 14:26
@TaiKamilla TaiKamilla self-assigned this Sep 4, 2023
@TaiKamilla TaiKamilla added the enhancement New feature or request label Sep 4, 2023
@NathanHGit NathanHGit requested review from NathanHGit and removed request for a team September 6, 2023 07:56
Copy link
Contributor

@NathanHGit NathanHGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the username should be displayed instead of the id and I guess the select should be usuable from the grid line editor as the owner field does.

image

@AntoineRelief AntoineRelief changed the base branch from 2.1.x to beta September 14, 2023 11:08
@MwanPygmay MwanPygmay self-requested a review September 26, 2023 08:12
Copy link
Contributor

@MwanPygmay MwanPygmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As suggested by Nathan in above comment, added support in grids, and in summary cards: mimicked behavior of users questions.
  • Repaired a bug regarding tagbox widget linked to one of my previous tickets (people tagbox would raise an error).
    People question should work fine now.

@MwanPygmay MwanPygmay changed the base branch from beta to 2.x.x March 20, 2024 12:07
@NathanHGit NathanHGit self-assigned this Mar 22, 2024
@MwanPygmay
Copy link
Contributor

MwanPygmay commented Apr 17, 2024

@Matthis-M-ReliefApps

  • Changed number of char for search to be 2
  • Is it wanted that no user is fetched until we start searching?

@AntoineRelief
Copy link
Collaborator

request to do for pagination:

query {
users(limitItems: 25) {
userid
firstname
lastname
emailaddress
}
totalCount:users {
aggregate_regionid_min
aggregate_count
}
}

@AntoineRelief AntoineRelief marked this pull request as draft April 25, 2024 12:24
@AntoineRelief
Copy link
Collaborator

AntoineRelief commented Apr 25, 2024

@MwanPygmay

putting as draft this one

A few things to change:

  • it should be possible to use it as multi select or single select ( perhaps an input could do it )
  • in that case, when displaying in a grid, it should also be reflected ( I don't know if using the same type of question would allow it )
  • too many users are fetched at the same time!! We should use pagination. One thing we can do, front-end side, is NOT to use our API, but instead, build a query to CS directly from the front-end. Or, in a first time, edit our back-end so we can do pagination over users list
  • check if in export we have the same format than when displaying as a grid
  • check if other widgets support the question type

I'll assign you the ticket on devops

@MwanPygmay
Copy link
Contributor

  • New type of question: singlepeople, which is a single select
  • Behaviour adapted in grid, can be filtered
  • Fetching users ten by ten, with load on scroll.
  • corrected export.
  • Supported in summary cards and editor

@MwanPygmay MwanPygmay marked this pull request as ready for review May 6, 2024 11:42
Copy link
Collaborator

@Matthis-M-ReliefApps Matthis-M-ReliefApps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to double-check but look overall fine

Copy link
Collaborator

@Matthis-M-ReliefApps Matthis-M-ReliefApps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR from the GOAT Matthieu

@AntoineRelief AntoineRelief changed the title feat/AB#74292_ABC-Create-people-picker-question feat/AB#74292 People picker Jun 3, 2024
@AntoineRelief
Copy link
Collaborator

@Matthis-M-ReliefApps @MwanPygmay

most of it is working as expected, but I still see one issue 😅

the charts are not working:

Capture d’écran 2024-06-14 à 09 22 26

We should see similar data than the one we see in other widgets
I'm putting back as draft the PR, and putting back in todo the ticket

@AntoineRelief AntoineRelief marked this pull request as draft June 14, 2024 07:37
@MwanPygmay MwanPygmay marked this pull request as ready for review June 19, 2024 10:11
@MwanPygmay
Copy link
Contributor

Still to be done:

  • Sorting in the aggregations (sorting in the layouts is already handled).
  • Bug: When filling out a form with the people picker and navigating directly to a grid displaying the people, the names do not appear immediately. The page needs to be reloaded to display the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants