Add parameter to allow starting a cluster with TLS, that does not use TLS connections for inter-shard communication #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TLS for inter-shard communication
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new parameter tlsCluster to control whether cluster communication uses TLS, decoupling inter-shard TLS connections from standard TLS usage. Key changes include:
- Adding a new tlsCluster parameter (default True) to the redis_std.py and env.py constructors.
- Updating the createCmdArgs method in redis_std.py to include the TLS flag conditionally.
- Updating the README.md file to document the new --tlsCluster option.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RLTest/redis_std.py | Added tlsCluster parameter and updated createCmdArgs to check it. |
| RLTest/env.py | Added tlsCluster initialization in the Defaults class and init. |
| README.md | Documented the new --tlsCluster option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.