-
Notifications
You must be signed in to change notification settings - Fork 21
[MOD-10236] Add serialization to SVS index #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a3ee719
to
7af26da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
main comments are regarding visibility :)
missing review for svs_extensions.h
and svs_utils.h,
will go over with @rfsaliev
d7602a1
to
3fb87dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO a lot of unnecessary code duplication.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 96.84% 96.54% -0.31%
==========================================
Files 122 125 +3
Lines 7393 7578 +185
==========================================
+ Hits 7160 7316 +156
- Misses 233 262 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!!
Had a few comments :)
Also, we need to implment a complemantry logic to serialize SVSIndex from the tiered index, and a tiered index ctor that will recieve an svs index loaded from disk
But IMO should be done in a seperate PR.
This PR refactors the serialization logic for vector indexes by introducing a clear abstraction layer via the Serializer base class. Both HNSWSerializer and SVSSerializer now inherit from this interface, enabling:
Each index (e.g., HNSWIndex, SVSIndex) implements its own saveIndexFields method to handle template- and implementation-specific data.
This PR also introduces support for saving/loading SVS indexes and validating their internal consistency.
Specifically: