-
Notifications
You must be signed in to change notification settings - Fork 34
docs(web-dev-server): include prism-esm in default importmap for client highlighting #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(web-dev-server): include prism-esm in default importmap for client highlighting #2735
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@zeroedin @bennypowers Hi, |
|
@saraDahanCode I've reviewed the changes in The code correctly implements what @Zerodin suggested - adding prism-esm and its related paths to the importmap in During testing I saw errors related to @floating-ui/utils still resolving to null. `@floating-ui/utils': '/node_modules/@floating-ui/utils/dist/floating-ui.utils.browser.min.mjs,` |
|
patternfly/patternfly-elements#2945 removed the dependency on floating-ui. This released in |
|
@bennypowers Hi, Uncaught TypeError: Failed to resolve module specifier "@floating-ui/dom". Relative references must start with either "/", "./", or "../". |
You still have pfe-core 5.0.3: https://github.com/saraDahanCode/red-hat-design-system/blob/e3433d895f2d5fbdcbf4d7024d83b5ae6d4fc69c/package.json#L288 |
Related to: #2693
What I did
Added prism-esm to the default importmap in web-dev-server.config.js to enable client-side highlighting for
code-block.Testing Instructions
Run npm run dev and open the
client-side-highlightingdemo insidecode-blockto verify client highlighting works correctly.Notes to Reviewers
Extracted from POC PR #2725.