fix(icon): clear displayed icon when icon attribute is removed or empty #2727
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 593f167 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
@bennypowers @zeroedin @marionnegp Hi, |
bennypowers
changed the title
bennypowers
previously requested changes
Nov 10, 2025
added 5 commits
November 11, 2025 14:29
saraDahanCode
force-pushed
the
fix/2464-rh-icon-empty-attribute-not-removed
branch
from
1e99d3d to
bd24da9
Compare
added 3 commits
November 11, 2025 14:53
bennypowers
approved these changes
Dec 3, 2025
github-project-automation
bot
moved this from Review 🔍
to Done ☑️
in Red Hat Design System
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug: #2464
What I did
Fixed to clear the icon when the icon attribute is removed or empty.
Added test-remove-icon-dynamic.html to demonstrate dynamic removal.
Testing Instructions
Open the demo file in a browser.
Click "Remove Icon" and confirm the icon disappears.
Verify no console errors occur.
Notes to Reviewers
Only affects dynamic icon removal; existing usage is unchanged.
Check that the demo behaves as expected.