[DO NOT MERGE] Add verifier registrar unreachable test scenario #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis pull request extends the test framework to support a new push-attestation agent and adds a functional test for the verifier/registrar unreachable scenario by enhancing the shared test helpers library, updating existing test scripts, adding systemd drop-in configurations for the new service, and introducing two new functional test suites. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Quote all variable expansions in lib.sh (e.g. ${__INTERNAL_limeTPMDetails}) to avoid word-splitting or globbing issues when paths contain spaces.
- The systemd drop-in creation for keylime_agent and keylime_push_model_agent is almost identical—consider looping or extracting a helper function to reduce duplication.
- The new push-attestation and unreachable-registrar test scripts share a lot of setup logic; think about moving common phases into test-helpers to simplify and DRY up the tests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Quote all variable expansions in lib.sh (e.g. ${__INTERNAL_limeTPMDetails}) to avoid word-splitting or globbing issues when paths contain spaces.
- The systemd drop-in creation for keylime_agent and keylime_push_model_agent is almost identical—consider looping or extracting a helper function to reduce duplication.
- The new push-attestation and unreachable-registrar test scripts share a lot of setup logic; think about moving common phases into test-helpers to simplify and DRY up the tests.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Koncpa
force-pushed
the
pk_server_temp_unreachable
branch
from
975b3c1 to
d24e0a2
Compare
| rlAssertGrep "ERROR - Agent $AGENT_ID does not exist on Registrar" $rlRun_LOG -E | ||
| rlRun "limeCreateTestPolicy" | ||
| #check agent status in logs | ||
| rlAssertGrep "Error.*Connection refused" $(limeAgentLogfile) |
Check warning
Code scanning / shellcheck
SC2046 Warning test
|
|
||
| rlPhaseStartTest "Stop verifier and check adding keylime agent" | ||
| rlRun -s "keylime_tenant -v 127.0.0.1 -t 127.0.0.1 -u $AGENT_ID --runtime-policy policy.json -c add ${TENANT_ARGS}" 1 | ||
| rlAssertGrep "Failed to establish a new connection.*Connection refused" $rlRun_LOG -E |
Check warning
Code scanning / shellcheck
SC2086 Warning test
| rlRun -s "keylime_tenant -v 127.0.0.1 -t 127.0.0.1 -u $AGENT_ID --runtime-policy policy.json -c add ${TENANT_ARGS}" 1 | ||
| rlAssertGrep "Failed to establish a new connection.*Connection refused" $rlRun_LOG -E | ||
| rlRun "limeWaitForAgentStatus $AGENT_ID 'Connection Refused'" 1 | ||
| rlAssertGrep "GET invoked from" $(limeAgentLogfile) |
Check warning
Code scanning / shellcheck
SC2046 Warning test
Koncpa
force-pushed
the
pk_server_temp_unreachable
branch
from
d24e0a2 to
aec78a5
Compare
Koncpa
force-pushed
the
pk_server_temp_unreachable
branch
2 times, most recently
from
8fb2ca2 to
ee371a1
Compare
Koncpa
changed the title
Koncpa
force-pushed
the
pk_server_temp_unreachable
branch
2 times, most recently
from
88eba4e to
a9aa2b0
Compare
Collaborator
Author
|
Reported possible bug: keylime/keylime#1819 |
Test scenario check how is agent behaved when verifier and registrar are unreachable during initial registration or attestation.
Koncpa
force-pushed
the
pk_server_temp_unreachable
branch
from
a9aa2b0 to
7145c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for the push attestation agent in test helpers, refactor tests for generic agent service invocation, and introduce new functional tests covering unreachable registrar/verifier and push-attestation scenarios
New Features:
Enhancements:
Tests: