Skip to content

Conversation

MichaelChirico
Copy link
Member

This continues #5845 to use test(options= more frequently.

  • I included only suites that are not involved in any existing non-draft PR for which I am not the author
    • Basically, that leaves the main tests.Rraw and froll.Rraw as the other suites which need this treatment after we further burn down our PR pile
  • I'm adapting an approach to use local() blocks rather than several or dozens of consecutive identical options= provisions. This cleans up the code a fair amount. Basically, the end state here is that options() should only be called in a test suite (1) under options= or (2) inside a local() call. We can enforce this with {lintr} eventually.

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@1b3998e). Learn more about missing BASE report.
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7111   +/-   ##
=========================================
  Coverage          ?   98.50%           
=========================================
  Files             ?       79           
  Lines             ?    14754           
  Branches          ?        0           
=========================================
  Hits              ?    14533           
  Misses            ?      221           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen ben-schwen merged commit a080833 into master Jul 15, 2025
11 checks passed
@ben-schwen ben-schwen deleted the test-options2 branch July 15, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants