Add trunc.IDate #4868
Open
Add trunc.IDate #4868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4868 +/- ##
==========================================
- Coverage 99.61% 99.47% -0.15%
==========================================
Files 72 73 +1
Lines 13916 14570 +654
==========================================
+ Hits 13862 14493 +631
- Misses 54 77 +23
Continue to review full report at Codecov.
|
jangorecki
reviewed
Jan 9, 2021
| @@ -83,6 +83,21 @@ round.IDate = function (x, digits=c("weeks", "months", "quarters", "years"), ... | |||
| years = ISOdate(year(x), 1L, 1L))) | |||
| } | |||
|
|
|||
| trunc.IDate = function (x, units = c("weeks", "months", "quarters", "years"), start.on.monday = TRUE, ...) { | |||
There was a problem hiding this comment.
I would make this more flexible than cut.Date(), though I'm not sure the exact signature that's most helpful.
Is this too flexible?
week_start = "Mon"
offset = if (is.numeric(week_start)) (week_start + 2L) %% 7L else switch(week_start,
M = , Mon = , Monday = 4L,
Tu = , Tue = , Tuesday = 5L,
W = , Wed = , Wednesday = 6L,
Th = , Thu = , Thursday = 0L,
F = , Fri = , Friday = 1L,
Sa = , Sat = , Saturday = 2L,
Su = , Sun = , Sunday = 3L)
|
Let's make this behave like |
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation with some POSIXlt calls.
Should closes #4335.