fix: add Deeploy lifecycle delete metadata#428
Draft
cristibleotiu wants to merge 1 commit into
Draft
Conversation
What changed: - advance Deeploy lifecycle generation on create/update/scale specs - send structured delete payloads using discovered deployment generation - extend focused tests and local two-node testbed for stale delete ordering Why: - make receiver-side stale command protection possible for Deeploy apps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Sender-side delete dedupe from DEEPLOY-0002 does not prevent a delayed older delete from stopping a newer updated app. This branch adds the Deeploy sender metadata needed by the receiver ordering guard.
Dependency
Depends on
Ratio1/naeural_core#206. Do not deploy this branch without core support for structuredDELETE_CONFIGpayloads; old core reproducesTypeError: unhashable type: 'dict'when receiving dict delete content.Validation
PYTHONPATH=/mnt/c/workspaces/r1_wrapper/worktrees/deeploy-0003/naeural_core:/mnt/c/repos/naeural_client /home/bleot/venvs/umbrella313/bin/python -m unittest discover -s extensions/business/deeploy/tests -p 'test_*.py'-> 65 tests passedPYTHONPATH=/mnt/c/workspaces/r1_wrapper/worktrees/deeploy-0003/naeural_core:/mnt/c/repos/naeural_client /home/bleot/venvs/umbrella313/bin/python -m py_compile extensions/business/deeploy/deeploy_const.py extensions/business/deeploy/deeploy_mixin.py extensions/business/deeploy/tests/test_delete_pipeline_commands.py extensions/business/deeploy/tests/test_create_requests.py docker-compose/deeploy-testbed/validate_delete_workflow.pyDEEPLOY_TESTBED_CORE_PATH=/mnt/c/workspaces/r1_wrapper/worktrees/deeploy-0003/naeural_core/naeural_core docker compose -f docker-compose/deeploy-testbed.yaml -f docker-compose/deeploy-testbed.local-core.yaml config --quietokgit diff --checkKnown Blocker
python -m unittest extensions.business.deeploy.test_deeployis still blocked by the existing circular import around_UtilsBaseMixin; focused Deeploy tests pass.