refactor: Make preconditionFn part of all context menu items
#9558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
changed the title
preconditionFn part of all context menu items
maribethb
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9179
Proposed Changes
This PR updates the
ContextMenuRegistryinterfaces such thatCoreRegistryItemincludes an optionalpreconditionFn, which is required forActionRegistryItem, and optional forSeparatorRegistryItem. Previously,SeparatorRegistryItemdid not have it at all, so there was no way to restrict separators to particular scopes other than the soft-deprecated and less-flexiblescopeTypefield.