Modifies data for shaded plots to use the centre of the Bayes distribution#114
Merged
DrPaulSharp merged 4 commits intoRascalSoftware:mainfrom Jan 14, 2025
Merged
Modifies data for shaded plots to use the centre of the Bayes distribution#114DrPaulSharp merged 4 commits intoRascalSoftware:mainfrom
DrPaulSharp merged 4 commits intoRascalSoftware:mainfrom
Conversation
StephenNneji
approved these changes
Jan 14, 2025
Contributor
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Looks good, please see comment
RATapi/utils/plotting.py
Outdated
| """ | ||
| data = PlotEventData() | ||
|
|
||
| # We need to take a copy of results and SLD in case the data to plot is modified later |
Contributor
There was a problem hiding this comment.
Do you have a scenario in mind for this? Or is one of our plots modifying the data?
Collaborator
Author
There was a problem hiding this comment.
Yup, a few lines below this we change data.reflectivity and data.sld if we are plotted a shaded plot - this is the switch of data that this PR is for. I'll change the comment to clarify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.