Recycle transaction fees instead of rewarding block authors - #3053
Recycle transaction fees instead of rewarding block authors#3053UnArbosFive wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-signal scrutiny (34-day-old account, zero public repos), mitigated by repository admin status and substantive merged work; no Gittensor association found. Branch targets main. Static analysis confirms that native and EVM fee imbalances reduce both issuance ledgers consistently, while Alpha-paid fees are converted and recycled atomically from the subnet account. No dependencies, origins, storage layout, CI paths, or AI-review trust-boundary files are changed. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the current diff. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN; newer GitHub account but established repository administrator with substantial contributions. Overlapping PRs address distinct changes. The implementation consistently recycles native TAO, Alpha-paid, and EVM fees without rewarding block authors. Tests cover issuance consistency, authorless Alpha payments, zero-TAO payers, and atomic rollback. The description matches the implementation, the runtime spec version is bumped to 444, and no migration is required. Static inspection found no issue requiring runtime confirmation or an auto-fix. FindingsNo findings. ConclusionThe change is coherent, appropriately tested, and preserves the relevant issuance and atomicity invariants. It is ready to merge. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
Why is the TAO being recycled, but the TAO from the ALPHA burned? Why wouldn't we also recycle the TAO from the ALPHA-paid fee (it says |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
Restore transaction-fee handling so block-producing validators do not receive transaction-fee revenue. Transaction fees are recycled by reducing TAO issuance. Existing AMM swap-fee behavior is unchanged.
Changes
Issuance invariants
Tests verify that:
Verification
cargo fmt --all -- --checkcargo test --package subtensor-transaction-fee --libSKIP_WASM_BUILD=1 cargo test --package node-subtensor-runtime --test evm_transaction_feecargo clippy --package subtensor-transaction-fee --all-targets -- -D warnings