Skip to content

Conversation

super-gith
Copy link

拉取/合并请求描述:(PR description)

[
为什么提交这份PR (why to submit this PR)
Add bsp ra6e1-fpb.

请提供验证的bsp和config (provide the config and bsp)
bsp/renesas/ra6e1-fpb

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [*] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [* ] 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:master
  • 设置PR number为 \ Set the PR number to:10762
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 master 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Sep 30, 2025
Copy link

github-actions bot commented Sep 30, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: kurisaW

Changed Files (Click to expand)
  • bsp/renesas/re6e1-fpb/.api_xml
  • bsp/renesas/re6e1-fpb/.config
  • bsp/renesas/re6e1-fpb/.gitignore
  • bsp/renesas/re6e1-fpb/.ignore_format.yml
  • bsp/renesas/re6e1-fpb/.secure_azone
  • bsp/renesas/re6e1-fpb/.secure_xml
  • bsp/renesas/re6e1-fpb/.settings/standalone.prefs
  • bsp/renesas/re6e1-fpb/EventRecorderStub.scvd
  • bsp/renesas/re6e1-fpb/JLinkLog.txt
  • bsp/renesas/re6e1-fpb/JLinkSettings.ini
  • bsp/renesas/re6e1-fpb/Kconfig
  • bsp/renesas/re6e1-fpb/README.md
  • bsp/renesas/re6e1-fpb/SConscript
  • bsp/renesas/re6e1-fpb/SConstruct
  • bsp/renesas/re6e1-fpb/board/Kconfig
  • bsp/renesas/re6e1-fpb/board/SConscript
  • bsp/renesas/re6e1-fpb/board/board.h
  • bsp/renesas/re6e1-fpb/board/ports/SConscript
  • bsp/renesas/re6e1-fpb/board/ports/gpio_cfg.h
  • bsp/renesas/re6e1-fpb/buildinfo.gpdsc
  • bsp/renesas/re6e1-fpb/configuration.xml
  • bsp/renesas/re6e1-fpb/docs/picture/fpb-ra6e2.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930112238070.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930112518592.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930112622622.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930112711356.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930113003433.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930114454018.png
  • bsp/renesas/re6e1-fpb/docs/picture/image-20250930115014947.png
  • bsp/renesas/re6e1-fpb/docs/picture/jflash.png

📊 Current Review Status (Last Updated: 2025-09-30 15:25 CST)

  • kurisaW Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666 Rbb666 requested a review from Copilot September 30, 2025 04:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the RA6E1-FPB development board by including a new Board Support Package (BSP). The PR adds essential CMSIS 6 core header files to support ARM Cortex-M microcontrollers and provides the foundational infrastructure for the RA6E1-FPB board.

Key changes include:

  • Addition of CMSIS 6 core header files for ARM Cortex-M microcontrollers
  • Support files for multiple Cortex-M variants (M0, M0+, M1, SC000)
  • Architecture-specific implementations for ARMv7-M, ARMv8-M, and ARMv8.1-M features

Reviewed Changes

Copilot reviewed 46 out of 166 changed files in this pull request and generated 2 comments.

File Description
bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/*.h CMSIS 6 core header files providing ARM Cortex-M microcontroller support
cmsis_version.h CMSIS version definitions for core components
core_cm*.h Cortex-M core peripheral access layer headers for different variants
m-profile/*.h ARM M-profile specific implementations for cache, MPU, PMU, and PAC features

Comment on lines +95 to +96
/* \brief Specifies MAIR_ATTR number */
#define MAIR_ATTR(x) ((x > 7 || x < 0) ? 0 : x)
Copy link
Preview

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] [naming] 函数名 MAIR_ATTR 不够清晰。建议使用更具描述性的名称如 MAIR_ATTR_INDEXMAIR_ATTR_VALIDATE。 / [naming] Function name MAIR_ATTR is unclear. Consider using a more descriptive name like MAIR_ATTR_INDEX or MAIR_ATTR_VALIDATE."

Suggested change
/* \brief Specifies MAIR_ATTR number */
#define MAIR_ATTR(x) ((x > 7 || x < 0) ? 0 : x)
/* \brief Specifies MAIR attribute index */
#define MAIR_ATTR_INDEX(x) ((x > 7 || x < 0) ? 0 : x)

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块是原厂生成文件,可以不用修改

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,谢谢。我也觉得不用改。AI建议改的。

…ile/armv8m_mpu.h


二进制数据转16进制

Co-authored-by: Copilot <[email protected]>
@Rbb666
Copy link
Member

Rbb666 commented Sep 30, 2025

  1. 请在评论区附上正常运行的截图
  2. 需要在 .github/ALL_BSP_COMPILE.json 文件中 nxp_renesas 中添加此 BSP 的路径,这样 ci 就可以进行编译看护

@super-gith
Copy link
Author

image

@super-gith
Copy link
Author

image


开发板正面外观如下图:

![image-20250930115014947](G:\testRTT\rt-thread\bsp\renesas\re6e1-fpb\docs\picture\image-20250930115014947.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md 中的图片链接填写不正确

| IIC | 支持 | 软件 |
| WDT | 支持 | |
| RTC | 支持 | |
| ADC | 支持 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请确认这些外设是否有都验证过,没有通过验证的先不要添加

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中间文件请删除,不要提交

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该也是中间文件,建议添加到 .gitignore 中

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@Rbb666
Copy link
Member

Rbb666 commented Sep 30, 2025

PR 标题建议作者描述清晰,此 PR 具体做了什么事情

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: Renesas BSP related with Renesas BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants