-
Notifications
You must be signed in to change notification settings - Fork 5.3k
add ra6e1-fpb #10762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add ra6e1-fpb #10762
Conversation
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_renesasReviewers: kurisaW Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-09-30 15:25 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the RA6E1-FPB development board by including a new Board Support Package (BSP). The PR adds essential CMSIS 6 core header files to support ARM Cortex-M microcontrollers and provides the foundational infrastructure for the RA6E1-FPB board.
Key changes include:
- Addition of CMSIS 6 core header files for ARM Cortex-M microcontrollers
- Support files for multiple Cortex-M variants (M0, M0+, M1, SC000)
- Architecture-specific implementations for ARMv7-M, ARMv8-M, and ARMv8.1-M features
Reviewed Changes
Copilot reviewed 46 out of 166 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/*.h | CMSIS 6 core header files providing ARM Cortex-M microcontroller support |
cmsis_version.h | CMSIS version definitions for core components |
core_cm*.h | Cortex-M core peripheral access layer headers for different variants |
m-profile/*.h | ARM M-profile specific implementations for cache, MPU, PMU, and PAC features |
/* \brief Specifies MAIR_ATTR number */ | ||
#define MAIR_ATTR(x) ((x > 7 || x < 0) ? 0 : x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] [naming] 函数名 MAIR_ATTR
不够清晰。建议使用更具描述性的名称如 MAIR_ATTR_INDEX
或 MAIR_ATTR_VALIDATE
。 / [naming] Function name MAIR_ATTR
is unclear. Consider using a more descriptive name like MAIR_ATTR_INDEX
or MAIR_ATTR_VALIDATE
."
/* \brief Specifies MAIR_ATTR number */ | |
#define MAIR_ATTR(x) ((x > 7 || x < 0) ? 0 : x) | |
/* \brief Specifies MAIR attribute index */ | |
#define MAIR_ATTR_INDEX(x) ((x > 7 || x < 0) ? 0 : x) |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块是原厂生成文件,可以不用修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,谢谢。我也觉得不用改。AI建议改的。
bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/m-profile/armv8m_mpu.h
Outdated
Show resolved
Hide resolved
…ile/armv8m_mpu.h 二进制数据转16进制 Co-authored-by: Copilot <[email protected]>
|
|
||
开发板正面外观如下图: | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md 中的图片链接填写不正确
| IIC | 支持 | 软件 | | ||
| WDT | 支持 | | | ||
| RTC | 支持 | | | ||
| ADC | 支持 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请确认这些外设是否有都验证过,没有通过验证的先不要添加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中间文件请删除,不要提交
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该也是中间文件,建议添加到 .gitignore 中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
PR 标题建议作者描述清晰,此 PR 具体做了什么事情 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
Add bsp ra6e1-fpb.
请提供验证的bsp和config (provide the config and bsp)
bsp/renesas/ra6e1-fpb
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up