Skip to content

Conversation

unicornx
Copy link
Contributor

清理的工作包括三部分:

  • 将独立的 "/**@{*/" 合并到 “@addtogroup group_thread_management” 中
  • 将 “/@}/” 修改为 / @} group_thread_management/,加上 group 名字后方便找到对应匹配的 “@{” 部分。
  • 删除 “include/rtthread.h” 中的 “@addtogroup” 命令,因为在这个头文件中并没有 doxygen 注释,针对函数体的 doxygen 注释基本上全部定义在其他 .c 文件中了。除了两个例外,一个是 rt_thread_inited_hookproto_t,这是一个定义在 include/rtthread.h 中的函数类型。另一个是 rt_thread_idle_sethook,这是一个已知的问题,具体解释看 include/rtthread.h 代码中的 FIXME。

Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:dev-doxygen-thread
  • 设置PR number为 \ Set the PR number to:10760
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 dev-doxygen-thread 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the dev-doxygen-thread branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added the Kernel PR has src relate code label Sep 29, 2025
Copy link

github-actions bot commented Sep 29, 2025

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/idle.c
  • src/scheduler_mp.c
  • src/scheduler_up.c
  • src/signal.c
  • src/thread.c

📊 Current Review Status (Last Updated: 2025-09-29 16:55 CST)

  • GorrayLi Pending Review
  • ReviewSun Pending Review
  • hamburger-os Pending Review
  • lianux-mm Pending Review
  • wdfk-prog Pending Review
  • xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

The cleanup involved three parts:

- Merging the standalone "/**@{*/" into
  "@addtogroup group_thread_management"

- Changing "/**@}*/" to "/** @} group_thread_management */",
  adding the group name makes it easier to find the matching "@{" part.

- Deleting the "@addtogroup" directive in "include/rtthread.h"
  because this header file doesn't have doxygen comments.
  All doxygen comments for function bodies are defined in other .c files.

  Note, we remian two doxygen comments for rt_thread_inited_hookproto_t
  and rt_thread_idle_sethook in the "include/rtthread.h".
  rt_thread_inited_hookproto_t is really defined here.
  For rt_thread_idle_sethook, please see FIXME comment for reason.

Signed-off-by: Chen Wang <[email protected]>
@unicornx unicornx requested a review from Rbb666 September 30, 2025 00:02
@Rbb666 Rbb666 merged commit 3dd4f71 into RT-Thread:master Sep 30, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kernel PR has src relate code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants