Skip to content

Conversation

Rbb666
Copy link
Member

@Rbb666 Rbb666 commented Sep 4, 2025

image

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Copy link

github-actions bot commented Sep 4, 2025

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/dfs/utest/Kconfig
  • components/dfs/utest/SConscript
  • components/dfs/utest/tc_dfs_api.c
  • components/dfs/utest/tc_posix_api.c

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/utest/default.cfg
  • .github/utest/dfs/dfs.cfg
  • .github/utest/kernel/object.cfg
  • .github/workflows/utest_auto_run.yml

📊 Current Review Status (Last Updated: 2025-09-06 13:50 CST)

  • Maihuanyi Pending Review
  • Rbb666 Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666 Rbb666 requested a review from supperthomas as a code owner September 5, 2025 02:11
@github-actions github-actions bot added the action github action yml imporve label Sep 5, 2025
@Rbb666 Rbb666 force-pushed the testcase branch 5 times, most recently from a9fb6be to 6b650e9 Compare September 5, 2025 04:13
@github-actions github-actions bot added the BSP label Sep 5, 2025
@Rbb666 Rbb666 requested a review from unicornx September 5, 2025 05:17
@Rbb666
Copy link
Member Author

Rbb666 commented Sep 5, 2025

@unicornx 汪老师可以帮忙review下?

Copy link
Contributor

@unicornx unicornx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了一些针对代码的 comments 外,还有以下哎general 的意见。

  • 我只看了 DFS 的部分,因为 DFS 部分是新增的,而且使用了新的 utest 组织方式。而且我主要 review 了新增部分的组织方式,对于实际的 DFS 测试内容,我建议请 DFS 的 maintainer review,这也是我们引入 maintainer 机制以及 utestcase 按照模块组织的最终目的。

  • 对于 DFS 的 utestcase 的组织,请再读一下 How-to add utest cases into RT-Thread for your module.. 目前看上去存在以下问题:

  • 建议将这个 pr 拆分成两个,或者在一个 pr 中作为两个 commit 分开提交,因为改动明显涉及两个 模块,一个是 DFS,一个是 core 部分的 mempool。

string "Filesystem type for test"
default "elm"
help
The filesystem type (e.g., elm, fat)
Copy link
Contributor

@unicornx unicornx Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help 部分应该和 RT_UTEST_DFS_MNT_PATH 一样说清楚这个配置项是为了 filesystem test 而用的。而且最好写成:Configure the xxxx which will be used in unit test. 不要一上来给个名字解释,但用户不知道这是干什么的。我们其实最好说清楚这是干什么的。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@Rbb666
Copy link
Member Author

Rbb666 commented Sep 5, 2025

除了一些针对代码的 comments 外,还有以下哎general 的意见。

  • 我只看了 DFS 的部分,因为 DFS 部分是新增的,而且使用了新的 utest 组织方式。而且我主要 review 了新增部分的组织方式,对于实际的 DFS 测试内容,我建议请 DFS 的 maintainer review,这也是我们引入 maintainer 机制以及 utestcase 按照模块组织的最终目的。

  • 对于 DFS 的 utestcase 的组织,请再读一下 How-to add utest cases into RT-Thread for your module.. 目前看上去存在以下问题:

  • 建议将这个 pr 拆分成两个,或者在一个 pr 中作为两个 commit 分开提交,因为改动明显涉及两个 模块,一个是 DFS,一个是 core 部分的 mempool。

  • 命名规范已规范命名
  • 没添加 RT_UTEST_USING_ALL_CASES 依赖是因为这个测试用例仅需要测试文件系统功能即可,如果添加RT_UTEST_USING_ALL_CASES 会导致CI编译报错(因为tc_dfs_api.c里面引用Kconfig中的配置,这些配置默认是不使能的),当然这些宏是可以添加到 .github\utest\default.cfg 的,但有点丑
  • 等review结束后,再拆分PR吧

Copy link
Contributor

@unicornx unicornx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仅 review 了 DFS 部分的和 utest 框架相关部分。具体的测试用例建议请 DFS 的 maintainer (如果有的话)检查。

@Rbb666 Rbb666 merged commit 8cca8d6 into RT-Thread:master Sep 6, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP Component testcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants