Skip to content

[Fix] <components>:finsh/shell.c F: char rt_hw_console_getchar(void), #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

illustriousness
Copy link
Contributor

When using char rt_hw_console_getchar(void),
some compilers may default to returning 255 instead of the expected -1, causing the condition if(ch < 0) at F: shell.c L:519 to fail and enter an erroneous loop.

Solution: Use the same int type return value as finsh_getchar

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented May 30, 2025

CLA assistant check
All committers have signed the CLA.

@BernardXiong
Copy link
Member

或者这部分应该调整成signed char

@illustriousness
Copy link
Contributor Author

我觉得可以解决问题 我这两天 改完测一下吧
改int 也只是为了和finsh_getchar的返回值保持统一
另外 您觉得是否可以对finsh支持以下功能呢
1 ctrl+back 按单词删除
2 ctrl+左右箭头 按单词切换光标
如果加的话 这些功能似乎需要新增一个宏定义 以条件编译的方式加入finsh组件?

@illustriousness
Copy link
Contributor Author

signed char同样可以 @BernardXiong

@Rbb666
Copy link
Member

Rbb666 commented Jun 13, 2025

我觉得可以解决问题 我这两天 改完测一下吧 改int 也只是为了和finsh_getchar的返回值保持统一 另外 您觉得是否可以对finsh支持以下功能呢 1 ctrl+back 按单词删除 2 ctrl+左右箭头 按单词切换光标 如果加的话 这些功能似乎需要新增一个宏定义 以条件编译的方式加入finsh组件?

感觉也不用,可以试着提个pr看下效果

@illustriousness
Copy link
Contributor Author

ok 那我这个pr先留着?

@BernardXiong
Copy link
Member

signed char同样可以 @BernardXiong

如果是 signed char 是可以达到效果的,建议使用这样的方式(在位宽上charint在大多数场合是不一致的,这个问题应该是在某些编译器下,char会按unsigned char默认来对待了)。也可以是这个PR更改成signed char的方式,谢谢

When using char rt_hw_console_getchar(void),
some compilers may default to returning 255 instead of the expected -1,
causing the condition if(ch < 0) at F: shell.c L:519 to fail and enter an erroneous loop.

Solution: Use the signed char type return value as rt_hw_console_getchar
Signed-off-by: Yucai Liu <[email protected]>
@illustriousness
Copy link
Contributor Author

好的 我已改成signed char作为 rt_hw_console_getchar的返回值

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants