Skip to content

[r2.19-rocm-enhanced] Update rocPrim usage for ROCm7 #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

mmakevic-amd
Copy link

Picked from #2972

@pramenku pramenku merged commit c4b157b into r2.19-rocm-enhanced Jun 6, 2025
3 of 7 checks passed
@pramenku pramenku deleted the r2.19-rocprim-fix branch June 6, 2025 08:17
@pramenku
Copy link

pramenku commented Jun 6, 2025

since rocprim is promoted via https://github.com/AMD-ROCm-Internal/manifest/pull/93 in mainline, need to merge to unblock

i-chaochen pushed a commit that referenced this pull request Jun 6, 2025
Co-authored-by: Jason Furmanek <Jason.Furmanek@amd.com>
i-chaochen added a commit that referenced this pull request Jun 6, 2025
Co-authored-by: mmakevic-amd <Milica.Makevic@amd.com>
Co-authored-by: Jason Furmanek <Jason.Furmanek@amd.com>
@i-chaochen
Copy link
Collaborator

i-chaochen commented Jun 13, 2025

@mmakevic-amd just realise that we need to backport this to develop-upstream...

@mmakevic-amd
Copy link
Author

@mmakevic-amd just realise that we need to backport this to develop-upstream...

No problem, I'll wait for weekly sync to get merged first (waiting for CPU tests to finish atm), so I can avoid rebasing it. Once that done, I'll backport this.

@mmakevic-amd
Copy link
Author

@mmakevic-amd just realise that we need to backport this to develop-upstream...

No problem, I'll wait for weekly sync to get merged first (waiting for CPU tests to finish atm), so I can avoid rebasing it. Once that done, I'll backport this.

Here is the PR #3003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants