Always enable PC sampling tests in CI #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Author
Author
Author
|
Author
Author
|
How are you all assigning auditors on this project? I don't know this project, and I keep showing up.... |
Contributor
|
This pull request has merge conflicts that need to be resolved. It cannot be imported to the ROCm/rocm-systems repo automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Enable PC sampling tests in our CI. Each test has a guard that should disable it based on the underlying architecture.
All PC sampling tests are disabled on non-GFX9 architectures. Stochastic PC sampling tests are disabled on MI2xx.
Associated Jira Ticket Number/Link
What type of PR is this? (check all applicable)
Technical details
Based on the following table, all PC sampling tests are disabled. This PR aims to always set the
ROCPROFILER_PC_SAMPLING_BETA_ENABLED=onto enable tests to run. However, we used cmake functions to guard running PC sampling tests on the architectures that do not support PC sampling (non gfx9 architectures). This way, the tests are shown as explicitly disabled on the architectures that do not support PC sampling feature.Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?