SWDEV-569101 - Resolve deadlock caused by graph packet batching when profiling is enabled #2084
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the signal list size in the HwQueueTracker to accommodate larger batch sizes for HIP graph operations. The change ensures the signal pool can handle at least DEBUG_HIP_GRAPH_BATCH_SIZE (256) signals instead of being limited to ROC_SIGNAL_POOL_SIZE (64).
- Signal list size now uses
std::max(ROC_SIGNAL_POOL_SIZE, DEBUG_HIP_GRAPH_BATCH_SIZE)to ensure sufficient capacity - Lookahead calculation updated from a fixed offset of 2 to
DEBUG_HIP_GRAPH_BATCH_SIZEfor consistency with the new sizing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
iassiour
force-pushed
the
users/iassiour/SWDEV-569101
branch
from
d1e2d4e to
b44711d
Compare
iassiour
changed the title
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakesroy
pushed a commit
that referenced
this pull request
Dec 1, 2025
Open
1 task
iassiour
force-pushed
the
users/iassiour/SWDEV-569101
branch
from
b44711d to
fab10f7
Compare
systems-assistant bot
pushed a commit
to ROCm/clr
that referenced
this pull request
Dec 2, 2025
DEBUG_HIP_GRAPH_BATCH_SIZE (#2084) [rocm-systems] ROCm/rocm-systems#2084 (commit 65b769e)
rakesroy
pushed a commit
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a deadlock in ActiveSignal when profiling and graph packet batching is enabled, that is introduced after #1354.
Technical Details
Added a timestamp check to the signal insertion logic. Previously, a new profiling signal was only created when the existing signal was still active (signal > 0). Added a second condition signal_list_[temp_id]->ts_ == ts to handle the case where the slot is already associated with the current timestamp.
Test Plan
Tested with the job from https://ontrack-internal.amd.com/browse/SWDEV-569101 and verified that it resolves the hang against with various combinations of ROC_SIGNAL_POOL_SIZE and DEBUG_HIP_GRAPH_BATCH_SIZE.
Test Result
The hang reported in https://ontrack-internal.amd.com/browse/SWDEV-569101 is now resolved.
Submission Checklist