SWDEV-569450 - Fix Unit_hipStreamBeginCaptureToGraph_CapturePartialInThreads #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Unit_hipStreamBeginCaptureToGraph_CapturePartialInThreads test by ensuring that when an event is recorded on a new stream during graph capture, it is properly removed from the previous stream's capture event list.
Key Changes:
- Added logic to erase the event from the previous capture stream before setting a new capture stream
- Prevents duplicate event tracking across multiple streams during graph capture operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
iassiour
force-pushed
the
users/iassiour/capturefix
branch
from
b826a04 to
fe3c8e6
Compare
iassiour
changed the title
iassiour
force-pushed
the
users/iassiour/capturefix
branch
3 times, most recently
from
6f35d03 to
73ac21e
Compare
anugodavar
approved these changes
Dec 2, 2025
| if (hipStream_t lastCaptureStream = e->GetCaptureStream()) { | ||
| if (hip::isValid(lastCaptureStream)) { | ||
| if ((lastCaptureStream != nullptr) && (lastCaptureStream != hipStreamLegacy)) { | ||
| reinterpret_cast<hip::Stream*>(e->GetCaptureStream())->EraseCaptureEvent(event); |
Contributor
There was a problem hiding this comment.
It Should get cleared during end capture.
Contributor
There was a problem hiding this comment.
Makes sense if same event is used again to record during capture.
iassiour
force-pushed
the
users/iassiour/capturefix
branch
from
73ac21e to
d392d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes the Unit_hipStreamBeginCaptureToGraph_CapturePartialInThreads test by ensuring that when an event is recorded on a new stream during graph capture, it is properly removed from the previous stream's capture event list.
Otherwise when the event is destroyed, it can lead to a dangled event reference in the original stream and cause a segfault.
Technical Details
Added logic to erase the event from the previous capture stream before setting a new capture stream
Prevents duplicate event tracking across multiple streams during graph capture operations.
Test Plan
Unit_hipStreamBeginCaptureToGraph_CapturePartialInThreads should pass
Test Result
Unit_hipStreamBeginCaptureToGraph_CapturePartialInThreads passes and does not show any warning in valgrind
Submission Checklist