-
Notifications
You must be signed in to change notification settings - Fork 81
[rocprofiler-compute] ROCm 7.2 RC 1 cherry pick #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vedithal-amd
wants to merge
10
commits into
release/rocm-rel-7.2
Choose a base branch
from
users/vedithal-amd/rocprofiler-compute-7.2-rc1
base: release/rocm-rel-7.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[rocprofiler-compute] ROCm 7.2 RC 1 cherry pick #2070
vedithal-amd
wants to merge
10
commits into
release/rocm-rel-7.2
from
users/vedithal-amd/rocprofiler-compute-7.2-rc1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* roll back json file processing logic for pc sampling * format cmake files * Revert "format cmake files" This reverts commit e64df65.
Force tencentos to use rhel-based bin since tencent is branched off of centos, which is branch of fedora. Verified rocprof-compute run correctly selects bin to use, and the roofline benchmark values look similar between runs on rhel vs tencentos4 docker images on same system. Signed-off-by: Carrie Fallows <[email protected]>
* Split roofline tests * Use N/A for missing values * Test eval_expression for no valid data * Fixed tests * Updated Changelog for N/A * Fixed platform specific test failure
* Implement AMDGPU driver info and GPU VRAM attributes in system info. section of analysis report. * Backward compatibility for rocprofiler-sdk avail module path migration * Fix roofline calculation where AI data points are N/A
feizheng10
approved these changes
Nov 28, 2025
* Only depepnd on amdsmi in profile phase * amdsmi interface tests should have common prefix for easier testing
* ChangeLog * Deprecation notice in old arch * Deprecation notice current arch * New config hash * Added Config deltas * Added metric description
feizheng10
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
organization: ROCm
project: rocprofiler-compute
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist