Skip to content

Conversation

@isaki001
Copy link
Contributor

Details

Do not mention proprietary info or link to internal work items in this PR.

Work item: "Internal", or link to GitHub issue (if applicable).

What were the changes?
Fix incomplete proxy-trace generation.

Why were the changes made?
Commit 08a7be2 removed two required proxy-counter updates.

How was the outcome achieved?
Added missing updateProxyOpCounter in sendProxyProgress and recvProxyProgress

Additional Documentation:
What else should the reviewer know?

Approval Checklist

Do not approve until these items are satisfied.

  • Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

@isaki001 isaki001 merged commit da18359 into ROCm:develop Nov 25, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants