Skip to content

Conversation

@atulkulk
Copy link
Contributor

@atulkulk atulkulk commented Nov 6, 2025

Details

Work item: LWPCLPAT-480

What were the changes?
Added new unit tests for AllReduce with Bias API

Why were the changes made?
To improve code quality.

How was the outcome achieved?
New tests were added.

Additional Documentation:
What else should the reviewer know?

Approval Checklist

Do not approve until these items are satisfied.

  • Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

@atulkulk atulkulk requested a review from a team as a code owner November 6, 2025 16:23
@atulkulk atulkulk marked this pull request as draft November 7, 2025 03:58
@atulkulk atulkulk force-pushed the ak_dev_arbias branch 2 times, most recently from 159cb6f to 38701c7 Compare November 13, 2025 03:24
@atulkulk atulkulk marked this pull request as ready for review November 13, 2025 03:25
@nusislam
Copy link
Contributor

LGTM. Need to merge with develop. Also, check what the CI failures are about.

@atulkulk atulkulk force-pushed the ak_dev_arbias branch 6 times, most recently from f3bb9ad to 8a1f930 Compare November 18, 2025 22:38
@atulkulk
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@alex-breslow-amd alex-breslow-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atulkulk atulkulk merged commit 7c12b0b into ROCm:develop Dec 3, 2025
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants