-
Notifications
You must be signed in to change notification settings - Fork 191
Added new unit tests for AllReduce with Bias API #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
159cb6f to
38701c7
Compare
38701c7 to
fed8802
Compare
nusislam
reviewed
Nov 13, 2025
fed8802 to
ab6cb65
Compare
Contributor
|
LGTM. Need to merge with develop. Also, check what the CI failures are about. |
wenkaidu
approved these changes
Nov 14, 2025
f3bb9ad to
8a1f930
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
8a1f930 to
ee5f3c7
Compare
This was referenced Nov 24, 2025
ee5f3c7 to
86ac092
Compare
86ac092 to
e533f35
Compare
alex-breslow-amd
approved these changes
Dec 1, 2025
Contributor
alex-breslow-amd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b3431ee to
dec4422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Work item: LWPCLPAT-480
What were the changes?
Added new unit tests for AllReduce with Bias API
Why were the changes made?
To improve code quality.
How was the outcome achieved?
New tests were added.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.