[Cherry-Pick] P2p batching hang-fix (#2011) #2035
Open
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prevent batching when send/recv bytes dont match, restore bit reversal for channel to part mapping, prevent batching beyond 32-nodes * correct computation for channel to part mapping * update changelog * disabling p2p-batching by default (cherry picked from commit 641c0eb)
nileshnegi
requested review from
a team,
AbandiGa,
AtlantaPepsi,
BertanDogancay,
JhaShweta1,
Kapil-Shyam-Pawar,
KawtharShafie,
Nikhil-Nunna,
PJAvinash,
PedramAlizadeh,
amd-mengshwu,
atulkulk,
corey-derochie-amd,
ddebonis-amd,
gilbertlee-amd,
haripriya-amd,
isaki001,
mberenjk,
mustafabar,
nawrinsu,
nusislam,
rahulvaidya20,
speriaswamy-amd,
thananon,
weilewei and
wenkaidu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 641c0eb)
Details
Work item:
Internal (SWDEV-565260)
What were the changes?
Why were the changes made?
Re-introducing bit-reversal for channels<->parts mapping prevents perf. regression on AINIC
Approval Checklist
Do not approve until these items are satisfied.