Optimize GDR buffer flushing for AMD hardware #2025
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenkaidu
approved these changes
Nov 3, 2025
thomas-huber
approved these changes
Nov 3, 2025
nusislam
approved these changes
Nov 3, 2025
thananon
approved these changes
Nov 4, 2025
Optimize GDR buffer flushing for AMD hardware with direct managed memory access by adding a netManaged parameter to ncclTopoNeedFlush that indicates hardware support for direct managed memory access from host, allowing the function to skip unnecessary flushing on AMD/HIP platforms when this feature is available.
ryanhankins
force-pushed
the
flush_net
branch
from
dd744ba to
dc2eb43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize GDR buffer flushing for AMD hardware with direct managed memory access by adding a netManaged parameter to ncclTopoNeedFlush that indicates hardware support for direct managed memory access from host, allowing the function to skip unnecessary flushing on AMD/HIP platforms when this feature is available.