Skip to content

Cherry-pick ([Profiler plugin] Fix segfault issue with profiler plugin (#1973)) #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: release/rocm-rel-7.1
Choose a base branch
from
Open

Cherry-pick ([Profiler plugin] Fix segfault issue with profiler plugin (#1973)) #2015

wants to merge 3 commits into from
+17 −10

Conversation

@corey-derochie-amd
Copy link
Contributor

@corey-derochie-amd corey-derochie-amd commented Oct 28, 2025

Cherry-pick of #1973

@rahulvaidya20 @yoqiu-amd @corey-derochie-amd
[Profiler plugin] Fix segfault issue with profiler plugin (ROCm#1973)
5390092 
* Fix profiler plugin segfault by correctly setting p2p->func

* Look for librccl-profiler.so instead of libnccl-profiler.so

Signed-off-by: rahulvaidya20 <[email protected]>

---------

Signed-off-by: rahulvaidya20 <[email protected]>
Co-authored-by: Yongjie Qiu <[email protected]>
@corey-derochie-amd
Copy link
Contributor Author

corey-derochie-amd commented Oct 28, 2025

Recreated #1987

mattwill-amd
mattwill-amd reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@mattwill-amd mattwill-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattwill-amd mattwill-amd mattwill-amd left review comments

@nileshnegi nileshnegi nileshnegi approved these changes

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@wenkaidu wenkaidu Awaiting requested review from wenkaidu wenkaidu is a code owner

@gilbertlee-amd gilbertlee-amd Awaiting requested review from gilbertlee-amd gilbertlee-amd is a code owner

@PedramAlizadeh PedramAlizadeh Awaiting requested review from PedramAlizadeh PedramAlizadeh is a code owner

@nusislam nusislam Awaiting requested review from nusislam nusislam is a code owner

@KawtharShafie KawtharShafie Awaiting requested review from KawtharShafie KawtharShafie is a code owner

@AtlantaPepsi AtlantaPepsi Awaiting requested review from AtlantaPepsi AtlantaPepsi is a code owner

@mberenjk mberenjk Awaiting requested review from mberenjk mberenjk is a code owner

@mustafabar mustafabar Awaiting requested review from mustafabar mustafabar is a code owner

@thananon thananon Awaiting requested review from thananon thananon is a code owner

@JhaShweta1 JhaShweta1 Awaiting requested review from JhaShweta1 JhaShweta1 is a code owner

@BertanDogancay BertanDogancay Awaiting requested review from BertanDogancay BertanDogancay is a code owner

@rahulvaidya20 rahulvaidya20 Awaiting requested review from rahulvaidya20 rahulvaidya20 is a code owner

@isaki001 isaki001 Awaiting requested review from isaki001 isaki001 is a code owner

@PJAvinash PJAvinash Awaiting requested review from PJAvinash PJAvinash is a code owner

@AbandiGa AbandiGa Awaiting requested review from AbandiGa AbandiGa is a code owner

@Nikhil-Nunna Nikhil-Nunna Awaiting requested review from Nikhil-Nunna Nikhil-Nunna is a code owner

@haripriya-amd haripriya-amd Awaiting requested review from haripriya-amd haripriya-amd is a code owner

@atulkulk atulkulk Awaiting requested review from atulkulk atulkulk is a code owner

@ddebonis-amd ddebonis-amd Awaiting requested review from ddebonis-amd ddebonis-amd is a code owner

@amd-mengshwu amd-mengshwu Awaiting requested review from amd-mengshwu amd-mengshwu is a code owner

@Kapil-Shyam-Pawar Kapil-Shyam-Pawar Awaiting requested review from Kapil-Shyam-Pawar Kapil-Shyam-Pawar is a code owner

@weilewei weilewei Awaiting requested review from weilewei weilewei is a code owner

@nawrinsu nawrinsu Awaiting requested review from nawrinsu nawrinsu is a code owner

@speriaswamy-amd speriaswamy-amd Awaiting requested review from speriaswamy-amd speriaswamy-amd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corey-derochie-amd @nileshnegi @amd-jnovotny @mattwill-amd @rahulvaidya20