Skip to content

New madengine CLI with unified interface for local and distribution #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
coketaste wants to merge 246 commits into
base: main
Choose a base branch
from
Open

New madengine CLI with unified interface for local and distribution #57

coketaste wants to merge 246 commits into from
+44,727 −6,167

Conversation

@coketaste
Copy link
Contributor

@coketaste coketaste commented Dec 5, 2025

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

coketaste added 30 commits July 3, 2025 12:40
@coketaste
Implemented a distributed solution which refactors current run_model …
71344f9 
…flow
@coketaste
Fixed the test cases for distributed solution
ea2dc0c
@coketaste
Updated the interface and fix the issue due to updating
bb64b73
@coketaste
Reorganize the cli interface of distributed solution
86d1790
@coketaste
Updated the interface of distributed solution and refine the code wit…
dd71dfa 
…h test coverage
@coketaste
Added setup.py for installation with dev
8236a7b
@coketaste
Fix the test case of distributed cli
0c42bbf
@coketaste
Fixed the flow of manifest and run_phase to work properly
f942a45
@coketaste
Updated setup.py for the cases of modern and legacy installation
08ff29b
@coketaste
Fixed and enhanced live log in build and run phases
d82d78e
@coketaste
Fixed the log generate for different phase, and correct log name
c848419
@coketaste
Fix the perf.csv generation in distributed execution
3e2a44c
@coketaste
Fixed the data which update to perf.csv
8a359ac
@coketaste
Fixed the columns in perf.csv due to parsing issue
ac32cbe
@coketaste
Fix the incorrect regex escaping in the container runner that prevent…
bb6d3fc 
…ed proper performance metric extraction
@coketaste
Update the patterns of performance and metric
a255c50
@coketaste
Fixed the issue of docker_image column in perf.csv
8988508
@coketaste
Improve the interface and reduce erro in registry flow
f0a10a7
@coketaste
Updated the flow of run phase, fix the docker pull, fix the creds ver…
8caae5c 
…ify before docker login
@coketaste
updated the tagged name for docker image and add a docker_image_tagge…
942e666 
…d field to the build manifest
@coketaste
Updated the sequence of operations in build phas
a7baa17
@coketaste
Fixed the registry_image
2e613ca
@coketaste
Update the registry_image
b4e7d22
@coketaste
Updated the process of run phase
d1ecb97
@coketaste
Refactored the file structure of package for distributed_cli
799cce7
@coketaste
Fixed the errors in unit tests
9875fda
@coketaste
Fix the error in unit test of distributed cli
168ffe5
@coketaste
Refactored constants to make design as best practices
756d82a
@coketaste
Cleanup:
9431d7f 
Simplified - No confusing multiple configuration files
Modern - Follows current Python packaging standards (PEP 621)
Maintainable - Single source of truth
Compatible - Works with all modern Python tools
@coketaste
Fixed the regex pattern
cf50f13
@coketaste
v2.0 development:
0698b2b 
(1) 6 launchers implementation for multigpu and mutlinode on k8s and slurm cluster.
(2) bugs fix for error handler
(3) cleanup deadcode
(4) update docs of project
@coketaste
Updated the gpu_vendor and guest_os fields in config
56a0de4
@coketaste
Updated README.md and its sections in docs
ff522cf
@coketaste
Updated the README and cleanup
b9f7634
@coketaste
Replace sleep to cat
8aff6df
@coketaste
Updated torchrun with run.sh pattern on k8s deployment
17f0d51
@coketaste
Updated Megatron-lm base image using ROCm/megatron-lm:latest
23eaded
@coketaste
Implemented report and database commands
912217b
@coketaste
Added the feature of perf superset to collect configs and multi-results
e7977cc
@coketaste
Fixed the k8s pvc issue
07753bd
@coketaste
Updated the context saving logic
c999f28
@coketaste
Reorganize unit tests, remove reduntant and edge cases, add examples …
780d3b9 
…of batch-manifest and update documentation of the feature of batch build
@coketaste
Make an universal soluton with docker exec
5942717
@coketaste
Replaced sleep with tail
70ca5cd
@coketaste
Fixed teh docker pull issue on compute node if the layer of image cra…
cd02965 
…shed
@coketaste
Removed MySQL database interface
4ca22a2
@coketaste
Updated the Megatron-lm launcher on both k8s and slurm
f05eee3
@coketaste
Updated k8s-configs megatron-lm and deepspeed
d1f07cf
@coketaste
Updated the config of gradient_accumulation_steps
096e337
@coketaste
Removed legacy madengine and its relative, use madengine as unified m…
77b9735 
…odern CLI with k8s and SLURM
@coketaste
Cleanup and enhance README of project
f336db1
@coketaste
Merge pull request #59 from ROCm/coketaste/refactor-dis-slurm
1af2531 
New madengine cli slurm distribution with 6 launchers
@coketaste
Fixed the vllm multinode on k8s
259df29
@coketaste
Fixed the format error in kubernetes
1438f7b
@coketaste
Implemented sglang-disagg launcher for slurm and k8s on multinode
7555c14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gargrahul gargrahul Awaiting requested review from gargrahul

@amathews-amd amathews-amd Awaiting requested review from amathews-amd

At least 2 approving reviews are required to merge this pull request.

Assignees

@coketaste coketaste

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coketaste @Boss2002n