-
Notifications
You must be signed in to change notification settings - Fork 2
Add multi distro support #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manoj-freyr
wants to merge
8
commits into
main
Choose a base branch
from
multiOs-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69bca87 to
0e3e0eb
Compare
- Added detect_distro() function to identify Linux distribution - Added package name translation for RHEL/SUSE equivalents - Added multi-distro package management functions (install_package, update_package_cache, map_packages) - Added Docker installation support for RHEL/CentOS and SUSE - Updated test files with proper cvs.lib imports for multi-distro functions Supports: Debian/Ubuntu (apt-get), RHEL/CentOS/Rocky/Alma (dnf), SUSE (zypper)
4910570 to
32b8a26
Compare
… commands - Replace hardcoded 'apt update' and 'apt-get install' with detect_distro() and install_package() - Add proper package name translation using map_packages() - Update all affected test files: - tests/health/install/install_babelstream.py - tests/health/install/install_rocblas.py - tests/health/install/install_rvs.py - tests/health/rocblas_cvs.py - tests/ibperf/install_ibperf_tools.py
1208344 to
189b025
Compare
solaiys
approved these changes
Dec 11, 2025
Contributor
solaiys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cijohnson
requested changes
Dec 11, 2025
Contributor
cijohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
sys.path.insert( 0, './lib' ) use in mulitple files, are they required with new cvs pkg?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds support to be OS agnostic and work for all linux distros
Technical Details
After the changes tried running install rvs commands:
pytest -vvv --log-file=../logs/rvs_cvs_test_mi325__install_rvs.log -s tests/health/install/install_rvs.py --cluster_file ./input/cluster_file/manojsk_cluster.json --config_file ./input/config_file/health/mi300_health_config.jsonUsed the same in RHEL, it works: