Merged
Conversation
alextmagro
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
alextmagro
force-pushed
the
mxfp8_cast_optimization
branch
from
630d87a to
74a82fc
Compare
ipanfilo
requested changes
Mar 27, 2026
ipanfilo
reviewed
Mar 30, 2026
ipanfilo
reviewed
Mar 31, 2026
ipanfilo
reviewed
Apr 3, 2026
benchmarks/cpp/CMakeLists.txt
Outdated
| ${TESTS_CPP_DIR} | ||
| ) | ||
|
|
||
| if(DEFINED ENV{NVTE_ROCM_ARCH}) |
Collaborator
There was a problem hiding this comment.
Consider using build_tools/rocm_utils.cmake instead
Contributor
Author
There was a problem hiding this comment.
I have refactored the Cmake file to use rocm_utils.cmake. This also added HIP to the project, and removed the offload-arch list.
benchmarks/cpp/CMakeLists.txt
Outdated
| -O3 | ||
| -DNDEBUG | ||
| -DUSE_ROCM | ||
| --offload-arch=${GPU_TARGETS} |
Collaborator
There was a problem hiding this comment.
offload-arch does not support lists.
benchmarks/cpp/CMakeLists.txt
Outdated
| set(CMAKE_CXX_COMPILER hipcc) | ||
| endif() | ||
|
|
||
| project(transformer_engine_benchmarks LANGUAGES CXX) |
Collaborator
There was a problem hiding this comment.
HIP? Looks like only CXX file is test_common
Open
alextmagro
force-pushed
the
mxfp8_cast_optimization
branch
from
1b3fdc7 to
be54090
Compare
ipanfilo
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves performance of HIP MXFP8 Cast Kernels -- see confluence page for details
Adds benchmarking scripts for reproducability