Skip to content

Conversation

@mgehre-amd
Copy link
Contributor

Motivation

The actions page doesn't make it obvious which job was running which target. To quickly find the last run of a given target,
extend the run name with that.
image

Technical Details

Include important job inputs in the name shown on the Actions/workflow page. This makes it easier to find the last job for a certain target.

Test Plan

I have used the same trick on other repos; beyond that, github actions are hard to test.

Test Result

Submission Checklist

Include important job inputs in the name shown on the Actions/workflow
page. This makes it easier to find the last job for a certain target.
id-token: write
contents: read

run-name: Release portable Linux PyTorch Wheels (${{ inputs.amdgpu_family }}, ${{ inputs.release_type }}, ${{ inputs.rocm_version }})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check if there is a character count limit here before github cuts the name off.

editing with dev tools, I think this will fit but we should confirm:

Image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is great! Thanks! Docs: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#run-name (right at the top, wonder how we missed that)

Let's make the same change to a few other workflows too :D maybe all in one PR?

release workflows:

workflow file run history
https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_portable_linux_packages.yml https://github.com/ROCm/TheRock/actions/workflows/release_portable_linux_packages.yml
https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_portable_linux_pytorch_wheels.yml https://github.com/ROCm/TheRock/actions/workflows/release_portable_linux_pytorch_wheels.yml
https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_windows_packages.yml https://github.com/ROCm/TheRock/actions/workflows/release_windows_packages.yml
https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_windows_pytorch_wheels.yml https://github.com/ROCm/TheRock/actions/workflows/release_windows_pytorch_wheels.yml
(?) https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_native_linux_packages.yml not triggered yet?
https://github.com/ROCm/TheRock/blob/main/.github/workflows/build_native_linux_packages.yml https://github.com/ROCm/TheRock/actions/workflows/build_native_linux_packages.yml

etc.

build workflows like https://github.com/ROCm/TheRock/actions/workflows/build_portable_linux_pytorch_wheels.yml would be useful too, since those are triggered manually as being able to scan the history helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

3 participants