Fixing hipdnn build topology #2335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mousdahl-amd
requested review from
BrianHarrisonAMD,
HereThereBeDragons,
ScottTodd,
geomin12 and
stellaraccident
BrianHarrisonAMD
approved these changes
Nov 27, 2025
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
Looks good to me assuming we don't hit any CI issues.
Thanks!
Contributor
Author
|
Only outstanding problem in CI is an unrelated rccl test timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When attempting to build hipDNN by itself (without the MIOpen plugin), it was trying to build MIOpen (and everything it depends on).
Technical Details
Test Plan
-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_HIPDNN=ON-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_MIOPEN_PLUGIN=ONTest Result