[release/7.10] Python script to promote a version from prerelease to release (#1973) #2298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to promote .tar.gz and wheels from release candidate to release (e.g. 7.10.0rc1 --> 7.10.0). Can work on a single file, partial matches or entire directory. Creates new files for the promotion. Has an option to delete the old prerelease version on successful promotion. As we have a few custom files that also contain the version, added a modified third-party `change_wheel_version.py` to be able to also change the version in those non-standard files inside the wheel. Works on Windows and Linux. Includes a promotion test. Issue #1891 --------- Co-authored-by: Scott Todd <[email protected]>
ScottTodd
changed the title
ScottTodd
approved these changes
Nov 25, 2025
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
This cherry-pick doesn't look essential, but okay.
We could also run this script from main instead of from the release branch.
Contributor
Author
|
i was thinking the same and then i thought maybe for history-tracking it might be good to also have the version we will use for this release also on the release branch? what do you think? |
Base automatically changed from
release/therock-7.10
to
users/arravikum/release_changes7.10
November 26, 2025 15:33
Member
|
Up to you. In general I want to limit the number of commits on release branches, but having a solid audit trail for releases is important too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick from main: 8834ca3
Allows to promote .tar.gz and wheels from release candidate to release (e.g. 7.10.0rc1 --> 7.10.0). Can work on a single file, partial matches or entire directory.
Creates new files for the promotion. Has an option to delete the old prerelease version on successful promotion.
As we have a few custom files that also contain the version, added a modified third-party
change_wheel_version.pyto be able to also change the version in those non-standard files inside the wheel.Works on Windows and Linux. Includes a promotion test.
Issue #1891