Skip to content

Conversation

@NicEastvillage
Copy link
Contributor

Fixes a bug where all matches (even Continue&Spawn) were stopped when a new match were requested.

@NicEastvillage NicEastvillage added the bug Something isn't working label May 30, 2025
@VirxEC
Copy link
Collaborator

VirxEC commented May 30, 2025

If you merge this into the master branch, you're going to be merging into the v0.7 WIP

You need to branch off the v0.6.10 tag into another branch

@VirxEC
Copy link
Collaborator

VirxEC commented May 30, 2025

Also, I'm hesitant to remove to line completely, because EndMatch resets the state of MatchStarter which is what we want when restarting the match just to ensure that we don't prematurely start a match from the old match info

@NicEastvillage
Copy link
Contributor Author

The StartMatch command already resets the MatchStarter. If any resetting is missing it should go there.

@NicEastvillage
Copy link
Contributor Author

From what I can tell the EndMatch command does nothing that StartMatch does not do already (if necessary), but I can test further tomorrow.

@VirxEC
Copy link
Collaborator

VirxEC commented May 30, 2025

Maybe it doesnt matter now that I patched the real bug

@NicEastvillage NicEastvillage merged commit a842210 into master May 31, 2025
3 checks passed
@NicEastvillage
Copy link
Contributor Author

You need to branch off the v0.6.10 tag into another branch

I did a trick and this branch is now master (small chance you have to re-clone the repo), while the v0.7 stuff is on the v0.7 branch.

Visually, before:
billede

After:
billede

@VirxEC
Copy link
Collaborator

VirxEC commented May 31, 2025

I rebased v0.7 on master

@VirxEC VirxEC deleted the cs_bug branch September 23, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants