Add support for launching via Heroic #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirxEC
requested changes
May 16, 2025
Collaborator
VirxEC
left a comment
VirxEC
left a comment
There was a problem hiding this comment.
Thanks for the PR! Heroic is very popular on Linux especially, and supporting it would be awesome.
I assume this PR has been tested (at least on Linux) and that it successfully launches the game.
VirxEC
approved these changes
May 16, 2025
Collaborator
VirxEC
left a comment
VirxEC
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution - just going to wait for East to take a peek.
NicEastvillage
approved these changes
May 16, 2025
Contributor
NicEastvillage
left a comment
NicEastvillage
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can't test it since I don't use Heroic. Let's assume it works :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a PR to add the ability to launch with the Heroic games launcher via the custom launcher setting. It's pretty simple, but I have no idea what the conventions are in this project, so please don't hesitate to provide feedback or bring up something I missed!