Skip to content

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 9, 2021

This adds a flash method for RIOTCtrl. The idea is, that with #13 an inherited class can easily override it, that e.g. with iotlabcli it only has to be called once for all nodes.

@miri64 miri64 added the enhancement New feature or request label Mar 9, 2021
@miri64 miri64 requested a review from fjmolinas March 9, 2021 16:46
fjmolinas
fjmolinas previously approved these changes Sep 9, 2021
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, nice makes sense to have this!

@miri64
Copy link
Member Author

miri64 commented Sep 9, 2021

Force pushed to trigger a new build. The one that succeeded was quite stale. Can you Re-ACK please.

fjmolinas
fjmolinas previously approved these changes Sep 9, 2021
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK!

@miri64
Copy link
Member Author

miri64 commented Sep 9, 2021

New pylint was not happy. Will provide fixes :-).

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK

@miri64 miri64 merged commit ba939f7 into RIOT-OS:master Sep 9, 2021
@miri64 miri64 deleted the riotctrl/enh/flash-function branch September 9, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants