sys/net/gnrc_tcp: minor style fixes#22232
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom May 5, 2026
Merged
Conversation
crasbe
added
Type: bug
Member
Author
|
I'll rebase this one once #22230 is merged |
maribu
added
the
State: waiting for other PR
maribu
changed the title
crasbe
added
State: needs rebase
- drop a few unused headers
- fix two linter warnings with regard to precision loss due to implicit
type conversion
- The type change in `gnrc_tcp_init()` may actually allow `-EEXIST`
returned by `_gnrc_tcp_eventloop_init()` to be correctly passed
through.
maribu
force-pushed
the
sys/net/gnrc_tcp/fix-compilation-on-glibc
branch
from
7d2e60e to
253deb7
Compare
maribu
removed
the
State: needs rebase
Member
Author
|
Thx ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Testing procedure
Changing the type from
kernel_pid_ttointingnrc_tcp_init()to also allow passing through errors will probably cause different code to be generated and allow proper error handling. Otherwise, this should be a no-op.Issues/PRs references
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: