dist/tools/ci/print_toolchain_versions.sh: also support git worktrees#22112
Open
mguetschow wants to merge 1 commit intoRIOT-OS:masterfrom
Open
dist/tools/ci/print_toolchain_versions.sh: also support git worktrees#22112mguetschow wants to merge 1 commit intoRIOT-OS:masterfrom
mguetschow wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
|
The static test has a (valid) remark about your change and a very valid remark about line 57 (not your code, but still a bug). Perhaps you can address at least these two shellcheck comments? It would be extra-kind if you also fixed the other ones while you're at it 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Inside git worktrees,
.gitis not a folder, but a regular file. The script currently explicitly checks for an existing folder. It is anyhow better to use git tooling to check that, so do this instead.Testing procedure
will print on
master:With this PR, it works as expected, also if not in a git worktree