drivers/ws281x: add SPI backend

[fabian18]

Contribution description

SPI is a well known technique to drive the ws281x LED strip.
This PR add this as a possible backend.
There is unfortunately a glitch that pulls MOSI high on spi_acquire which is falsely interpreted as a 1.

This can be googled as the "phantom bit problem" or the "first LED always green problem".
The trick is to generate a RESET condition so that all LEDs get clean data afterwards.

Testing procedure

It works very reliable for me.
USEMODULE+=ws281x_spi make -C tests/drivers/ws281x/ -f Makefile.same54-xpro.mk flash

BOARD := same54-xpro

CFLAGS += -DWS281X_BYTES_PER_DEVICE=4
CFLAGS += -DWS281X_PARAM_PIN="GPIO_PIN(PB, 27)"
CFLAGS += -DWS281X_PARAM_PIN_IN="GPIO_PIN(PB, 29)"
CFLAGS += -DWS281X_PARAM_NUMOF=144

USEMODULE += ws281x_spi
ifneq (,$(filter ws281x_spi,$(USEMODULE)))
  CFLAGS += -DWS281X_SPI_DEV="SPI_DEV(0)"
  CFLAGS += -DWS281X_SPI_CLK="KHZ(3200)"
  # exact timing for sk6812
  CFLAGS += -DWS281X_T_DATA_ONE_NS=600
  CFLAGS += -DWS281X_T_DATA_ZERO_NS=300
endif

include Makefile

Issues/PRs references

There was a previous PR #20218. The author is added in the implementation.

[fabian18]

IMG_3124.mp4

[crasbe]

Some style comments, I haven't tested it yet.

[riot-ci]

Murdock results

✔️ PASSED

38bd754 drivers/ws281x: remove units.h due to redefinition in ESP vendor header

Success	Failures	Total	Runtime
11002	0	11004	09m:29s

Artifacts

• Documentation preview

[benpicco]

Looks good, just some nits

[fabian18]

In file included from esp32.c:38:
../../build/pkg/esp32_sdk/components/esp_hw_support/port/esp32/include/soc/rtc.h:53:9: error: "MHZ" redefined [-Werror]
   53 | #define MHZ (1000000)
      |         ^~~
In file included from include/ws281x_params.h:24,
                 from esp32.c:33:
../../core/lib/include/macros/units.h:45:9: note: this is the location of the previous definition
   45 | #define MHZ(x) (KHZ(x) * 1000UL)
      |         ^~~

mhm 🙄

[fabian18]

Can I simply guard our macros in units.h?

[crasbe]

Can I simply guard our macros in units.h?

That would cause other issues because the ESP32 definition is not a function. So writing MHZ(12) would cause issues because the preprocessor would resolve that to 1000(12), which is a syntax error.

I think we had this issue before somewhere but I don't remember the solution.

[crasbe]

Can I simply guard our macros in units.h?

That would cause other issues because the ESP32 definition is not a function. So writing MHZ(12) would cause issues because the preprocessor would resolve that to 1000(12), which is a syntax error.

I think we had this issue before somewhere but I don't remember the solution.

#21522 (comment)

The solution there was also not to use units.h. Quite annoying.

[benpicco]

looks good to me

[fabian18]

Building application "senml_saul_example" for "adafruit-feather-nrf52840-express" with CPU "nrf52".

Cloning into '/tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/nrf5x_nrfx_mdk/nrf52'...
done.
HEAD is now at 11f57e5 nrfx 3.14.0 release
Cloning into '/tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/pkg/cmsis'...
done.
HEAD is now at 2b7495b85 Merge branch 'develop'
Cloning into '/tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/pkg/mpaland-printf'...
done.
HEAD is now at 0dd4b64 test(test_suite): added support for PRINTF_DISABLE_SUPPORT_EXPONENTIAL
Cloning into '/tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/pkg/nanocbor'...
done.
HEAD is now at 3e37004 Merge pull request #94 from slegouix/master
/opt/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/ws281x/ws281x_saul.o: in function `set_rgb_led':
ws281x_saul.c:(.text.set_rgb_led+0x28): undefined reference to `_xtimer_tsleep'
collect2: error: ld returned 1 exit status
make: *** [/tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/examples/advanced/senml_saul/../../../Makefile.include:734: /tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/senml_saul_example.elf] Error 1
make: Leaving directory '/tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/examples/advanced/senml_saul'
cat: /tmp/dwq.0.4752955123436924/14f39206fe38e44d7a2ff4513d5436ed/build/test-input-hash.sha1: No such file or directory
{"build/": 19276}

Seems like I have to keep the xtimer dependency.

[crasbe]

See https://github.com/RIOT-OS/RIOT/pull/22003/changes#r2741828124.

Changes were applied.