boards/sensebox_samd21: Add MTD definition#10802
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Jan 24, 2019
Merged
Conversation
MrKevinWeiss
added
Impact: minor
Contributor
|
I don't want to expect errors 😢 |
Contributor
|
Also fix the travis errors. |
MrKevinWeiss
added
the
Reviewed: 3-testing
aabadie
reviewed
Jan 17, 2019
| mtd_sdcard_t sensebox_sd_dev = { | ||
| .base = { | ||
| .driver = &mtd_sdcard_driver, | ||
| .page_size = 512, |
Contributor
There was a problem hiding this comment.
Does the page_size/pages_per_sector/sector_count attributes depend on the SD card used ? Then I think (not sure though) this should be overridable from the board config using macro.
Contributor
Author
There was a problem hiding this comment.
Thanks, moved to macros
leandrolanzieri
force-pushed
the
pr/boards/sensebox_samd21-mtd
branch
from
e0a1acd to
251fb35
Compare
Contributor
Author
Fixed |
Contributor
|
Squash please |
leandrolanzieri
force-pushed
the
pr/boards/sensebox_samd21-mtd
branch
from
16c9927 to
7cee12c
Compare
leandrolanzieri
force-pushed
the
pr/boards/sensebox_samd21-mtd
branch
from
7cee12c to
2625a86
Compare
Contributor
Author
|
@MrKevinWeiss squashed |
MrKevinWeiss
approved these changes
Jan 18, 2019
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Everything looks OK to me, I give some time for @aabadie to do a one over though!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds the needed MTD (Memory Technology Device) definition, using the SD card device that is already defined for the board (
mtd0), to use it .Testing procedure
This can be tested using the
pkg_fatfstest application. Check that the file system can be mounted and read and write operations are working.Issues/PRs references
None