fix(verify-pr): add explicit Issue Type field to Step 6d sub-task creation templates#245
Merged
Merged
Conversation
…ation templates Add `**Issue Type:** Sub-task` as the first field in all three jira.create_issue templates in Step 6d (review feedback, CI failure, and eval failure sub-tasks). Without this field, the LLM nondeterministically infers the issue type, causing ~40% of sub-tasks to be created as standalone Tasks instead of Sub-tasks with proper parent-child hierarchy. Add eval assertion to verify-pr eval 3 to validate that sub-task creation output specifies Issue Type as Sub-task. Implements TC-5181 Assisted-by: Claude Code
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR ensures Jira sub-tasks are created with the correct Issue Type and adds an eval guardrail so verify-pr workflows reliably produce Sub-tasks instead of standalone Tasks. Sequence diagram for Jira sub-task creation with explicit Issue TypesequenceDiagram
participant VerifyPRSkill
participant LLMSubAgent
participant JiraAPI
VerifyPRSkill->>LLMSubAgent: request create_sub_task
LLMSubAgent->>JiraAPI: jira.create_issue(IssueType Sub-task, Parent, Summary, Labels)
JiraAPI-->>LLMSubAgent: sub_task_created_with_parent
LLMSubAgent-->>VerifyPRSkill: return sub_task_issue_id
Flow diagram for verify-pr eval 3 Issue Type assertionflowchart TD
A[Run verify-pr eval 3] --> B[Capture jira.create_issue output]
B --> C[Check IssueType field]
C -->|IssueType Sub-task| D[Eval passes]
C -->|IssueType not Sub-task| E[Eval fails]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Eval Results
Eval Results: verify-pr
| Eval | Passed | Failed | Pass Rate |
|---|---|---|---|
| eval-1 | 12/12 | 0 | 100% |
| eval-2 | 11/11 | 0 | 100% |
| eval-3 | 15/15 | 0 | 100% |
| eval-4 | 10/10 | 0 | 100% |
| eval-5 | 10/10 | 0 | 100% |
| eval-6 | 10/10 | 0 | 100% |
Pass rate: 100% · Tokens: 43,655 · Duration: 239s
Baseline (64970afe): 98% · 39,589 tokens · 197s
Generated by sdlc-workflow/run-evals v0.13.1
Collaborator
Author
Verification Report for TC-5181 (commit 7632a77)
Overall: PASSAll acceptance criteria satisfied. The three Acceptance Criteria Verification
Scope ContainmentAll files in the diff match the task specification:
No out-of-scope files. No untracked files. Eval QualityEval result review detected (3-criteria match: author github-actions[bot] ✓, marker
Overall: 68/68 (100%) — improved from baseline 98% at This comment was AI-generated by sdlc-workflow/verify-pr v0.13.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**Issue Type:** Sub-taskas the first field in all threejira.create_issuetemplates in Step 6d (review feedback, CI failure, and eval failure sub-tasks) to ensure Jira creates Sub-tasks with parent-child hierarchy instead of standalone TasksBug Context
Without the explicit Issue Type field, the LLM nondeterministically infers the issue type when calling
createJiraIssue, causing ~40% of sub-tasks to be created as standalone Tasks (type 10014) instead of Sub-tasks (type 10015). Jira silently ignores theparentparameter for Tasks, breaking the parent-child hierarchy.Implements TC-5181
Test plan
jira.create_issuetemplates in Step 6d include**Issue Type:** Sub-taskas the first fieldclaude plugin validate plugins/sdlc-workflowpasses🤖 Generated with Claude Code
Summary by Sourcery
Ensure Jira sub-tasks created in the verify-pr workflow are explicitly typed as Sub-task to preserve parent-child hierarchy and add evaluation coverage for this behavior.
Bug Fixes:
Enhancements: